Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve economy menu #1996

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Improve economy menu #1996

merged 7 commits into from
Jun 29, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented Jun 26, 2022

I have refactored a bit economy menu, waiting for feedback.

@DidierRLopes DidierRLopes added the enhancement Enhancement label Jun 26, 2022
@JerBouma
Copy link
Contributor

Was already wondering when you would do this, will have a look tomorrow :)

@DidierRLopes
Copy link
Collaborator Author

Was already wondering when you would do this, will have a look tomorrow :)

Had a lot to catchup this week, but managed to have some time for this today! 😄 It wasn't as big of a change as I thought it would be as well tbf!

@DidierRLopes
Copy link
Collaborator Author

Also, nvm the tests, I'll fix them after we agree on some layout for the menu :)

@JerBouma
Copy link
Contributor

Think you want this on the same line (and a maximum amount of options to prevent overflowing):

│ Stored datasets:                                                                                                                                                                     │
│   macro    : United_States_CPI                                                                                                                                                       │
│   macro    : United_States_GDP                                                                                                                                                       │
│   macro    : United_States_RGDP                                                                                                                                                      │
│                                     

What if I want to plot GDP and S&P 500 together in an instant, can we give the ability to allow for that without needing to call both macro and index first? That was my initial idea with --store (and helps within a .openbb script). I get that --store is undesired though.

Idea: you can also plot data directly from the plot command if you correctly enter the stored dataset names. E.g. let's say I want to see the CPI of United States and the index of S&P 500. I know that macro's database name is United_States_CPI and I know that the index name is sp500 so I input this into plot and it automatically recognises where it needs to get the data from. Bit advanced, but we can expand on that in the guide so it makes sense to all and in due time allow for auto-filing.

@DidierRLopes
Copy link
Collaborator Author

Think you want this on the same line (and a maximum amount of options to prevent overflowing):

│ Stored datasets:                                                                                                                                                                     │
│   macro    : United_States_CPI                                                                                                                                                       │
│   macro    : United_States_GDP                                                                                                                                                       │
│   macro    : United_States_RGDP                                                                                                                                                      │
│                                     

What if I want to plot GDP and S&P 500 together in an instant, can we give the ability to allow for that without needing to call both macro and index first? That was my initial idea with --store (and helps within a .openbb script). I get that --store is undesired though.

Idea: you can also plot data directly from the plot command if you correctly enter the stored dataset names. E.g. let's say I want to see the CPI of United States and the index of S&P 500. I know that macro's database name is United_States_CPI and I know that the index name is sp500 so I input this into plot and it automatically recognises where it needs to get the data from. Bit advanced, but we can expand on that in the guide so it makes sense to all and in due time allow for auto-filing.

I was thinking that that is fine, what you are doing is just adding more data to the ram so you have a faster access to it.

I don't understand what you meant around the plotting question!

@JerBouma
Copy link
Contributor

What I am looking for is the ability to plot data without needing to plot it first with the other functions, e.g. macro, fred, index. Right now, I first need to use those commands (and get two separate plots) before I can combine a graph withmacro and fred data. That is kinda annoying.

Ideally, you want to plot both without needing to run the commands separately first. E.g. I say plot --y1 United_States_CPI --y2 sp500 and it figures out the data comes from macro and index.

@DidierRLopes
Copy link
Collaborator Author

What I am looking for is the ability to plot data without needing to plot it first with the other functions, e.g. macro, fred, index. Right now, I first need to use those commands (and get two separate plots) before I can combine a graph withmacro and fred data. That is kinda annoying.

Ideally, you want to plot both without needing to run the commands separately first. E.g. I say plot --y1 United_States_CPI --y2 sp500 and it figures out the data comes from macro and index.

But that is a different feature than what we have right now?

@JerBouma
Copy link
Contributor

Think it might be good as it is right now and we can create a PR later with more features? Then we can also start writing Guides on the menu.

@DidierRLopes DidierRLopes marked this pull request as ready for review June 29, 2022 11:04
@DidierRLopes
Copy link
Collaborator Author

@JerBouma let's get this merged then and then we can work on it a bit more. Yes?

@JerBouma
Copy link
Contributor

Oui oui!

@DidierRLopes
Copy link
Collaborator Author

Stamp? 😄

Do we want to create tickets for the tasks to improve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants