Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ta/bbands: when value contains a decimal: error: argument -s/--std: invalid check_positive value: '4.5' #1988

Merged
merged 9 commits into from
Jun 25, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Jun 25, 2022

Description

Fixes #1978 by switching type check from 'check_positive' to 'check_positive float'
Before:
(🦋) /crypto/ta/ $ bbands -s 4.5
usage: bbands [-l N_LENGTH] [-s N_STD] [-m S_MAMODE] [-h] [--export EXPORT]
bbands: error: argument -s/--std: invalid check_positive value: '4.5'

After:
image

Also fixes #1977 by switching labels
Before:
image

After:
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the enhancement Enhancement label Jun 25, 2022
@DidierRLopes
Copy link
Collaborator

Nice one @soggyomelette 😄

@DidierRLopes DidierRLopes merged commit 5790f0b into OpenBB-finance:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
3 participants