[Bug] ta/bbands: when value contains a decimal: error: argument -s/--std: invalid check_positive value: '4.5' #1988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1978 by switching type check from 'check_positive' to 'check_positive float'
Before:
(🦋) /crypto/ta/ $ bbands -s 4.5
usage: bbands [-l N_LENGTH] [-s N_STD] [-m S_MAMODE] [-h] [--export EXPORT]
bbands: error: argument -s/--std: invalid check_positive value: '4.5'
After:
Also fixes #1977 by switching labels
Before:
After:
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.