-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors when tickers can't be loaded #1986
Merged
DidierRLopes
merged 13 commits into
OpenBB-finance:main
from
stkerr:stkerr-balance-sheet-handle-error-tickers
Jun 25, 2022
Merged
Handle errors when tickers can't be loaded #1986
DidierRLopes
merged 13 commits into
OpenBB-finance:main
from
stkerr:stkerr-balance-sheet-handle-error-tickers
Jun 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stkerr
changed the title
Balance sheet handle errors when tickers can't be loaded
Handle errors when tickers can't be loaded
Jun 24, 2022
This is a nice addition. Is this ready to be reviewed? |
stkerr
force-pushed
the
stkerr-balance-sheet-handle-error-tickers
branch
from
June 25, 2022 13:32
31b89b0
to
32c7f15
Compare
@DidierRLopes all cleaned up and ready for your review! |
DidierRLopes
approved these changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, this is a very nice one.
I believe someone had in fact ask for this before at some point!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gracefully handles errors when certain tickers can't be loaded as part of
/stocks/ca
commands. This can happen for certain tickers like SPY. When a ticker can't be loaded, it is removed from the comparison set and the command continues if possible. An example of what happens is in the screenshot below.How has this been tested?
Manual testing and pytest
Checklist:
Others
pre-commit install
.pytest tests/...
.