Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed crypto load #1981

Merged
merged 4 commits into from
Jun 23, 2022
Merged

fixed crypto load #1981

merged 4 commits into from
Jun 23, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jun 22, 2022

Description

Coingecko and coinpaprika have effectively destroyed their OHLC commands. We now need to rely on yfinance alone for accurate data.

How has this been tested?

Ran the load function.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Jun 22, 2022
Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@colin99d colin99d merged commit e3daff2 into main Jun 23, 2022
@colin99d colin99d deleted the cryptoload branch June 23, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants