-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes command govp from crypto/defi #1980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems ok to me.
@montezdesousa let's use a better naming for titles. When we scroll through closed PRs having "fix 9999" is not helpful. Also, if you mention the ticker on the PR that you are fixing with some keywords, e.g. "this pr fixes #xxxx" then once this gets merged that issue gets closed automatically 😄 |
Ok sry about that, got it |
No need to say sorry!! I did it too back in the day, and then had issues making sense of the titles 😄 PS: for the name of the branch it actually makes sense to have the issue number since it's a one-off thing that you will have locally, and we delete the branch after merging anyway. |
Yes, makes sense! Rookie mistakes 😄 |
Description
Removes command govp from crypto/defi. As explained in #1936 the command was not working already because data was unavailable.
How has this been tested?
pytest tests/openbb_terminal/cryptocurrency/defi/test_defi_controller.py --record-mode=rewrite
Checklist:
Others
pre-commit install
.pytest tests/...
.