Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes command govp from crypto/defi #1980

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Removes command govp from crypto/defi #1980

merged 3 commits into from
Jun 24, 2022

Conversation

montezdesousa
Copy link
Contributor

@montezdesousa montezdesousa commented Jun 22, 2022

Description

Removes command govp from crypto/defi. As explained in #1936 the command was not working already because data was unavailable.

image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

pytest tests/openbb_terminal/cryptocurrency/defi/test_defi_controller.py --record-mode=rewrite

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added the bug Fix bug label Jun 22, 2022
@montezdesousa montezdesousa linked an issue Jun 22, 2022 that may be closed by this pull request
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok to me.

@DidierRLopes DidierRLopes changed the title Issue1936 Removes command govp from crypto/defi Jun 24, 2022
@DidierRLopes
Copy link
Collaborator

@montezdesousa let's use a better naming for titles. When we scroll through closed PRs having "fix 9999" is not helpful.

Also, if you mention the ticker on the PR that you are fixing with some keywords, e.g. "this pr fixes #xxxx" then once this gets merged that issue gets closed automatically 😄

@montezdesousa
Copy link
Contributor Author

@montezdesousa let's use a better naming for titles. When we scroll through closed PRs having "fix 9999" is not helpful.

Also, if you mention the ticker on the PR that you are fixing with some keywords, e.g. "this pr fixes #xxxx" then once this gets merged that issue gets closed automatically 😄

Ok sry about that, got it

@DidierRLopes
Copy link
Collaborator

@montezdesousa let's use a better naming for titles. When we scroll through closed PRs having "fix 9999" is not helpful.
Also, if you mention the ticker on the PR that you are fixing with some keywords, e.g. "this pr fixes #xxxx" then once this gets merged that issue gets closed automatically 😄

Ok sry about that, got it

No need to say sorry!! I did it too back in the day, and then had issues making sense of the titles 😄

PS: for the name of the branch it actually makes sense to have the issue number since it's a one-off thing that you will have locally, and we delete the branch after merging anyway.

@DidierRLopes DidierRLopes merged commit 8f6bd9c into main Jun 24, 2022
@montezdesousa
Copy link
Contributor Author

@montezdesousa let's use a better naming for titles. When we scroll through closed PRs having "fix 9999" is not helpful.
Also, if you mention the ticker on the PR that you are fixing with some keywords, e.g. "this pr fixes #xxxx" then once this gets merged that issue gets closed automatically 😄

Ok sry about that, got it

No need to say sorry!! I did it too back in the day, and then had issues making sense of the titles 😄

PS: for the name of the branch it actually makes sense to have the issue number since it's a one-off thing that you will have locally, and we delete the branch after merging anyway.

Yes, makes sense! Rookie mistakes 😄

@DidierRLopes DidierRLopes deleted the issue1936 branch July 4, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /crypto/defi/govp not working
3 participants