Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Broken ETF functionalities #1976

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

soggyomelette
Copy link
Contributor

@soggyomelette soggyomelette commented Jun 22, 2022

Description

Tries to solve #1972 by changing the code in stockanalysis_model.py to ensure it extracts the data from stockanalysis.com correctly

Also modifies the code in etf_controller.py to handle comparison between ETFs when spaces are used instead of commas (the parser isn't able to interpret arguments with spaces correctly)

Before:
image

After:
image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes added the bug Fix bug label Jun 22, 2022
@DidierRLopes
Copy link
Collaborator

Thank you!

Can you fix the tests as well please? @Chavithra can help you here if needed

@JerBouma
Copy link
Contributor

Fixed it for you, @soggyomelette

@soggyomelette
Copy link
Contributor Author

Fixed it for you, @soggyomelette

Thanks a lot! @Chavithra showed me how to do it but am travelling atm so hadn't done it yet

@JerBouma
Copy link
Contributor

Fixed it for you, @soggyomelette

Thanks a lot! @Chavithra showed me how to do it but am travelling atm so hadn't done it yet

No problem! Feel free to merge :)

@DidierRLopes DidierRLopes merged commit 0b9a81b into OpenBB-finance:main Jun 24, 2022
@DidierRLopes
Copy link
Collaborator

Nice one @soggyomelette 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants