Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff output to black workflow step #1975

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

stkerr
Copy link
Contributor

@stkerr stkerr commented Jun 21, 2022

Description

This change adds the --diff flag when running Black. This will make it print out what it would expect to see. This makes it easier for developers to understand what they need to change for Black to be happy. This removes the need for users to worry about running a wrong version of Black locally that may be looking at different things than the canonical Black is looking at.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

This change adds the --diff flag when running Black. This will make it print out what it would expect to see. This makes it easier for developers to understand what they need to change for Black to be happy.
@stkerr
Copy link
Contributor Author

stkerr commented Jun 21, 2022

@DidierRLopes @jmaslek can you review & merge this PR? Thanks!

@stkerr stkerr marked this pull request as ready for review June 21, 2022 21:36
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. I wish we had done this long ago 😓

@DidierRLopes DidierRLopes added the enhancement Enhancement label Jun 21, 2022
@DidierRLopes DidierRLopes merged commit cb66db1 into OpenBB-finance:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants