Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing menu dialogue for keys menu to be more apparent on how to add an api key #1971

Merged

Conversation

simmonsj330
Copy link
Contributor

Description

Changed menu so that users know what command to use to add a new api key. Specifically told users to see the help dialogue for each key because some keys need optional arguments such as the reddit api which needs client id, client secret, etc.

Screen Shot 2022-06-20 at 6 26 13 PM

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.

@simmonsj330 simmonsj330 added the enhancement Enhancement label Jun 20, 2022
@simmonsj330 simmonsj330 self-assigned this Jun 20, 2022
@minhhoang1023
Copy link
Contributor

Good call. As there can be multiple variables to be set, depending on the API.

Can you do me a favor and remove the "through environment variables"? People who use the installer would not know what is environment variable.

@DidierRLopes
Copy link
Collaborator

@minhhoang1023 if you still want changes on a PR, let's not accept it straight.

I was about to merge this because tests passed and a change was approved. I usually go back and check comments to see what happens but other person from the team may not.

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change wording to remove "through environment variables" following @minhhoang1023 suggestion

@DidierRLopes DidierRLopes merged commit 2c2112d into OpenBB-finance:main Jun 28, 2022
@simmonsj330 simmonsj330 deleted the keys_menu_dialogue_enhancement branch June 29, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants