Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] crypto/defi/sratio: Remove scientific notation in Chart title #1965

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

montezdesousa
Copy link
Contributor

Description

Tries to solve #1937 by just removing sratio command from the crypto/defi choices and help. Scientific notation was triggered by unreasonable Luna staking ratio coming from Terra FCD. Didn't remove call_sratio or any other related functions, since source data might be fixed in the future. Please let me know if I should remove this as well as any other related code.

image

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

pytest tests/openbb_terminal/cryptocurrency/defi/test_defi_controller.py --record-mode=rewrite

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@montezdesousa montezdesousa added the bug Fix bug label Jun 20, 2022
@montezdesousa montezdesousa changed the title Issue1937 [Bug] crypto/defi/sratio: Remove scientific notation in Chart title Jun 20, 2022
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@minhhoang1023 minhhoang1023 merged commit 2386bd2 into main Jun 24, 2022
@DidierRLopes DidierRLopes deleted the issue1937 branch July 4, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] crypto/defi/sratio: Remove scientific notation in Chart title
3 participants