Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto api fixes #1959

Merged
merged 64 commits into from
Jul 6, 2022
Merged

Conversation

northern-64bit
Copy link
Contributor

@northern-64bit northern-64bit commented Jun 17, 2022

Description

Fixes in the crypto menu for the api. This involves giving many view functions default values and changing some and adding doc strings.

How has this been tested?

These changes needs to be tested since I don't have the required api keys in order to test the changes. Some tests fail and I don't have the knowledge to fix them so help would be appreciated.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@minhhoang1023 minhhoang1023 added the enhancement Enhancement label Jun 18, 2022
Copy link
Contributor

@minhhoang1023 minhhoang1023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@northern-64bit about the market command, that was specific to the coin loaded, e.g. ETH. I tried out other coins and that works well.

We could replace the value with N/A to reflect the absence of data.

@minhhoang1023
Copy link
Contributor

@northern-64bit Tested and working well! Very nice job on this :)

A minor thing - can we remove the long URL, and keep the short one that you have? It's very looong! 😅
image

@minhhoang1023
Copy link
Contributor

then let's get it merged!

Copy link
Contributor

@minhhoang1023 minhhoang1023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEGOOO 🚀

@minhhoang1023 minhhoang1023 merged commit 5188884 into OpenBB-finance:main Jul 6, 2022
@northern-64bit northern-64bit deleted the Crypto-API-fixes branch July 6, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants