Fix crypto/defi/vaults not showing for default and -k lp #1957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solving issue #1940 where vaults were not being displayed. Error occurred because 'NaN' values on the APY field are being replaced by "NA" before the sort_values method acted on it, so it was trying to compare str to float. Just changed the replace of 'NaN' values to after the sort_values method.
Before:
After:
How has this been tested?
pytest tests/openbb_terminal/cryptocurrency/defi/test_coindix_model.py --record-mode=rewrite
pytest tests/openbb_terminal/cryptocurrency/defi/test_coindix_view.py --record-mode=rewrite
Others
pre-commit install
.pytest tests/...
.