Fixing fails to deliver bug and resulting NaN values in dataframe bug #1956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1904 where an HTTP 404 error was occurring due to bad .zip download links to the SEC website. There were a handful of .zip files with very slightly different links than the rest of the urls. An additional bug was found and fixed where when reading the csv from the zip file it could not convert NaN values to int.
Tested with the following which resulted in a yaml file rewrite:
pytest /Users/jamessimmons/Desktop/OpenBB/OpenBBTerminal/tests/openbb_terminal/stocks/dark_pool_shorts/test_sec_model.py --record-mode=rewrite
Others
pre-commit install
.pytest tests/...
.