Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed warnings bug which does not display data if there is an inf value data point #1948

Merged

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Jun 15, 2022

Fixes #1906
This bug stems from trying to calculate the Interest Coverage Ratio but the calculation return inf if it does not have the variables needed for the calculation, which occurs if the website we are scraping the data from does not have certain data points. This PR addresses this by adding functionality to the lambda_int_or_round_float function by identifying if there is an 'inf' and denoting it as '~' when viewing table.

Due to the function being within the helper_funcs.py file there was no testing run.

Screen Shot 2022-06-15 at 12 01 19 AM

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 added the bug Fix bug label Jun 15, 2022
@simmonsj330 simmonsj330 self-assigned this Jun 15, 2022
@colin99d colin99d merged commit f9f7177 into OpenBB-finance:main Jun 17, 2022
@simmonsj330 simmonsj330 deleted the warnings_infinity_to_integer_bug branch June 29, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
3 participants