Fixing scorr and sentiment dataframe indexing bug #1947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1883 where sentiment and scorr were not working correctly due to the dataframe running into an indexing error from different length lists
Tested with:
pytest tests/openbb_terminal/stocks/comparison_analysis/test_finbrain_model.py --rewrite-expected
Where it did not change any files so only pushing with one modified file: finabrain_model.py
Others
pre-commit install
.pytest tests/...
.