Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing future warnings bug by switching from append to concat. #1943

Merged

Conversation

simmonsj330
Copy link
Contributor

@simmonsj330 simmonsj330 commented Jun 13, 2022

Description

Fixed #1886 by changing from append to concat to get rid of future warnings. Tested with:
pytest tests/openbb_terminal/stocks/dark_pool_shorts/test_finra_model.py --rewrite-expected
This did not rewrite any files, so only modifying one file: finra_model.py

Screen Shot 2022-06-13 at 6 55 38 PM

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@DidierRLopes DidierRLopes merged commit c30f6c8 into OpenBB-finance:main Jun 14, 2022
@simmonsj330 simmonsj330 deleted the finra_model_futurewarning_bug branch June 14, 2022 05:14
@simmonsj330 simmonsj330 restored the finra_model_futurewarning_bug branch June 14, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
3 participants