Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify input arguments between Terminal and Crypto API usage #1942

Merged
merged 9 commits into from
Jun 24, 2022

Conversation

minhhoang1023
Copy link
Contributor

@minhhoang1023 minhhoang1023 commented Jun 13, 2022

In Crypto API, there are multiple places where users have to load exchange-specific ID (e.g. btc-bitcoin), instead of using the symbol (e.g. btc) as in the terminal. This fixes the issue, such that input arguments will be the same whether it's via the Terminal or using API.

Examples:

  • From Crypto API: Load ticker btc-bitcoin

image

  • From Terminal: Load ticker btc

image

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@minhhoang1023 minhhoang1023 added the enhancement Enhancement label Jun 20, 2022
@minhhoang1023 minhhoang1023 marked this pull request as ready for review June 20, 2022 10:14
@minhhoang1023 minhhoang1023 changed the title API Refactor Unify input arguments between Terminal and API usage Jun 20, 2022
@minhhoang1023 minhhoang1023 changed the title Unify input arguments between Terminal and API usage Crypto API enhancement - unify input arguments between Terminal and API usage Jun 20, 2022
@minhhoang1023 minhhoang1023 changed the title Crypto API enhancement - unify input arguments between Terminal and API usage Unify input arguments between Terminal and Crypto API usage Jun 20, 2022
@DidierRLopes DidierRLopes merged commit 7c597be into main Jun 24, 2022
@DidierRLopes DidierRLopes deleted the api-refactor branch July 4, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants