Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DCF glitch #1932

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Fix for DCF glitch #1932

merged 4 commits into from
Jun 14, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Jun 12, 2022

Description

This fixes the current glitch with the DCF command. It also switches the web scraping to pandas read_html, which should make the feature much more robust in the event of future website changes.

How has this been tested?

Generated a dcf.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label Jun 12, 2022
@piiq piiq merged commit b6300e9 into main Jun 14, 2022
@piiq piiq deleted the fixdcf branch June 14, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants