Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated install instruction for jupyterlab #1929

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

sugatoray
Copy link
Contributor

@sugatoray sugatoray commented Jun 10, 2022

Description

Since there is no folder as jupyterlab/gst or jupyterlab/gst-settings, the install instruction will result in error.

  • Fix: replaced jupyterlab/gst* with jupyterlab/openbb*

image

  • Summary of the change / bug fix.
  • Link # issue, if applicable. NA
  • Screenshot of the feature or the bug before/after fix, if applicable. NA
  • Relevant motivation and context. See above.
  • List any dependencies that are required for this change. NA

How has this been tested? NA

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

- removed jupyterlab/gst* with jupyterlab/openbb*
@sugatoray
Copy link
Contributor Author

sugatoray commented Jun 10, 2022

cc: @jmaslek

I saw your interview over Python Bytes. This is quite something! 🚀

🎥 YouTube Video: https://youtu.be/BbqvRqMbVFU

@DidierRLopes DidierRLopes added the bug Fix bug label Jun 11, 2022
@DidierRLopes
Copy link
Collaborator

Nice catch!! Thank you!

@DidierRLopes
Copy link
Collaborator

cc: @jmaslek

I saw your interview over Python Bytes. This is quite something! 🚀

🎥 YouTube Video: https://youtu.be/BbqvRqMbVFU

Don't hype the man up 🤣 (jk ❤️ )

@DidierRLopes DidierRLopes merged commit 1ea7557 into OpenBB-finance:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants