-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing default view and ascending order in cglosers and cggainers #1923
Fixing default view and ascending order in cglosers and cggainers #1923
Conversation
hmmm. The market cap still sorts in reverse order
Also having to have the user type out You are also getting a warning which can be directly applied to pycoingecko_model ( |
After doing James requests, for the test to pass you need to do: |
4ccddca
to
c409255
Compare
@jmaslek Sorting is in ascending order where the lowest market cap would put it at the highest market cap rank. For example bitcoin is the 1 market cap rank and appears at the top when sorting by rank but appears at the bottom when sorting by market cap itself |
I see. One could technically sort on the negative rank, but I think the user should understand why the sorting is in reverse order for the rank. So just add the test and you are good to go! |
962262c
to
d147142
Compare
Description
Fixes #1905
Made default cglosers sort by Market Cap [$] and switched ordering of sorting from descending to ascending.
Others
pre-commit install
.pytest tests/...
.