Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing no data label and test files #1922

Merged

Conversation

simmonsj330
Copy link
Contributor

Description

Fixes #1916 where now there is only one message stating that there is no data available. Additionally adds testing.

  • [ x] Summary of the change / bug fix.
  • [ x] Link # issue, if applicable.
  • [x ] Screenshot of the feature or the bug before/after fix, if applicable.
  • [ x] Relevant motivation and context.
  • [ x] List any dependencies that are required for this change.

Screen Shot 2022-06-09 at 3 16 00 PM

How has this been tested?

pytest tests/openbb_terminal/stocks/fundamental_analysis/test_business_insider_view.py --rewrite-expected

Checklist:

Others

  • [ x] I have performed a self-review of my own code.
  • [ x] I have commented my code, particularly in hard-to-understand areas.
  • [ x] My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • [ x] New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@simmonsj330 simmonsj330 requested a review from jmaslek June 9, 2022 19:20
@simmonsj330 simmonsj330 added the bug Fix bug label Jun 9, 2022
@jmaslek jmaslek merged commit 4ad367d into OpenBB-finance:main Jun 10, 2022
@simmonsj330 simmonsj330 deleted the business_insider_nodata_label_fix branch June 14, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] No Data Available label shows twice for business insider mgmt
2 participants