Fixes bug #1907 scraping management data

[simmonsj330]

Description

Fixes management bug #1907 where it was not scraping the management data when calling 'mgmt' for any ticker.

• [ x] Summary of the change / bug fix.
• [ x] Link # issue, if applicable.
• Screenshot of the feature or the bug before/after fix, if applicable.
• [ x] Relevant motivation and context.
• List any dependencies that are required for this change.

How has this been tested?

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

Checklist:

• Update our Hugo documentation following these guidelines.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding scripts file.

Others

• [ x] I have performed a self-review of my own code.
• [ x] I have commented my code, particularly in hard-to-understand areas.
• [ x] My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
• [ x] New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

[jmaslek]

Welcome aboard!

Tests can be rerun using pytest tests/openbb_terminal/stocks/fundamental_analysis/test_business_insider_model.py --rewrite-expected. (same for the view test)

Only other comment would be that in the case when data is not found, there is a print in both model and view, resulting in two prints

2022 Jun 07, 16:01 (🦋) /stocks/fa/ $ mgmt
No management information in Business Insider for IONQ

Data not available

Could limit to one

[Chavithra]

Hi @simmonsj330,

Here I remind the points from @jmaslek and add an extra.

FIXING PYTEST
From @jmaslek.
Running the following command to get rid of the pytest error :
pytest tests/openbb_terminal/stocks/fundamental_analysis/test_business_insider_model.py --rewrite-expected

REMOVING ERROR MESSAGE
From @jmaslek.
We should remove the error message from the model.
Maybe it should raise an exception that can be caught by the view.

FUNCTION REFACTORING
The original function is way too long if you have some extra time it worth refactoring.
Rule of thumb that I use : if it takes more than 30 seconds to understand a function it is probably too complex.
We can split the function to make it simpler to understand.

BUG
The bug itself seems to be fixed.