Clarify values by re-ordering rows in enterprise value report #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-organizes the rows in the enterprise value report so that they are more logically presented. They previously were presented directly in the order as the data provider returned them, which wasn't great for human consumption. This meant that tickers were down at the bottom of the list and the values that sum to compute EV were not in any reasonable order and the EV itself was intermixed with other numbers, making it hard to identify.
This PR puts the stock ticker and price first, then it puts all the rows below it that sum to be the enterprise value, with the EV at the bottom.
The command is reached with
/stocks/fa/fmp/enterprise
while a ticker has been loaded.How has this been tested?
I've tested the change locally and ran it several time with different tickers. The
pre-commit
tests all passed as well.Checklist:
Others
pre-commit install
.pytest tests/...
.