-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip predictions in reports if prediction package is missing. #1900
Skip predictions in reports if prediction package is missing. #1900
Conversation
…/stkerr/OpenBBTerminal into stkerr-prediction-error-handling
Thanks @stkerr! Great catch here. I tested it and the console.print doesn't print to the terminal (which presumably makes sense since its through paper mill). But the report runs without TF installed, so this bug is squashed. @martinb-bb and @piiq : we should improve the pred api so that certain models are still available in certain cases. For example, the mc techniques are just numpy arrays so it should be usable even if tf is not installed. |
That's a great idea @jmaslek! Will look into this. |
Co-authored-by: James Maslek <[email protected]>
Description
This PR does two main changes:
This enables the report to still be generated and used, even if no prediction capabilities are present.
How has this been tested?
I set up a local build with no prediction packages installed and with the feature flag disabled. I then ran the report with
reports/equity TSLA
and several other tickers. I confirmed that the reports generated successfully and that the prediction tab had a message about the prediction capabilities being missing.Checklist:
Others
pre-commit install
.pytest tests/...
.