Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-fill routine scripts and add new scripts #1889

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Auto-fill routine scripts and add new scripts #1889

merged 5 commits into from
Jun 2, 2022

Conversation

JerBouma
Copy link
Contributor

@JerBouma JerBouma commented Jun 1, 2022

Description

Just felt like we could use more scripts. Also the bar at the bottom now rotates between scripts as a little neat feature for people to play with. In time, we should have a script for all menus.

See how it looks below:
Screenshot 2022-06-01 at 20 04 58

The following is done:

  • Add in more scripts and shorten some. It makes little sense if you have 30 tasks in one script, who checks all of that as a routine?
  • Rename scripts to make them conform with one standard
  • Add in comments to all of them
  • Autocomplete exe and searches in the routines folder.
  • Randomly select one of the scripts in the bar below

Question to @DidierRLopes: do you want the scripts with_inputs in here? With no explanation it is really weird to work with. E.g. the fact you need to use -i and add tickers.

How has this been tested?

Not needed.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@JerBouma JerBouma added the docs Code documentation label Jun 1, 2022
@JerBouma JerBouma marked this pull request as ready for review June 1, 2022 18:13
@JerBouma
Copy link
Contributor Author

JerBouma commented Jun 2, 2022

@DidierRLopes Wanna share your opinion and/or approve?

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay on this. It's bank holiday in UK and have been packing stuff!

I really like this.

I was thinking that the next step is looking into the file and if there is a $ARGV we can ask the user to provide the parameter and if it doesn't throw an error saying that that routine needs an argument. We can do this in another PR!

@JerBouma JerBouma merged commit b976503 into OpenBB-finance:main Jun 2, 2022
@JerBouma JerBouma deleted the routines branch June 2, 2022 14:57
@JerBouma
Copy link
Contributor Author

JerBouma commented Jun 2, 2022

Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants