Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests and bump pandas version #1888

Merged
merged 5 commits into from
May 31, 2022
Merged

Fix tests and bump pandas version #1888

merged 5 commits into from
May 31, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented May 31, 2022

This fixes our broken CI

@piiq piiq added bug Fix bug dependencies Work related to dependencies labels May 31, 2022
@piiq piiq requested a review from Chavithra May 31, 2022 11:04
@Chavithra
Copy link
Contributor

Chavithra commented May 31, 2022 •
edited
Loading

This error is only with pandas 1.4.2 :

  • File : tests/openbb_terminal/alternative/covid/test_covid_controller.py
  • Error : ValueError: Specified \n as separator or delimiter. This forces the python engine which does not accept a line terminator. Hence it is not allowed to use the line terminator as separator.

I don't have the issue with pandas 1.3.5

Looks like pandas forbids using \n as CSV separator, so lines like this are forbidden :

pd.read_csv(country_file, sep="\n", index_col=None)

Fixed it.

Chavithra
Chavithra approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@Chavithra Chavithra merged commit 35ba7fd into main May 31, 2022
@Chavithra Chavithra deleted the fix-tests branch May 31, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chavithra Chavithra Chavithra approved these changes

Assignees
No one assigned
Labels
bug Fix bug dependencies Work related to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piiq @Chavithra