Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for reports an easy exit when something fails and other fixes #1876

Merged
merged 2 commits into from
May 27, 2022

Conversation

DidierRLopes
Copy link
Collaborator

We can now early exit a notebook report when an input is not valid. And this logic can all be handled within terminal.
Screenshot 2022-05-27 at 01 10 06

This is how we can do it.
Screenshot 2022-05-27 at 01 13 52

Extra: Fixes stocks/dd/sec command and also openbb.stocks.fa.models.yahoo_finance.get_info.

@DidierRLopes DidierRLopes added bug Fix bug enhancement Enhancement labels May 27, 2022
@DidierRLopes DidierRLopes requested review from jmaslek and piiq May 27, 2022 00:17
@DidierRLopes DidierRLopes merged commit 6aa487b into main May 27, 2022
@DidierRLopes DidierRLopes deleted the improve-reports branch May 30, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants