Improved fraud function #1855
Merged
Improved fraud function #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidierRLopes
requested changes
May 22, 2022
| @@ -251,6 +270,7 @@ def display_fraud(ticker: str, export: str = "", help_text: bool = False): | |||
| if help_text: | |||
| console.print(help_message) | |||
| export_data(export, os.path.dirname(os.path.abspath(__file__)), "dupont", df) | |||
| return | |||
There was a problem hiding this comment.
I was just doing it to match the other return so pylint would not throw an error.
| default=False, | ||
| help="Shows the details for calculating the mscore", | ||
| ) | ||
| parser.add_argument( |
There was a problem hiding this comment.
let's have it true by default
There was a problem hiding this comment.
Are you sure? These calculations are kind of "in the weeds" and will not be valuable to most people.
| ticker: str, | ||
| export: str = "", | ||
| help_text: bool = False, | ||
| color: bool = True, |
There was a problem hiding this comment.
let's have color True and not being optional
DidierRLopes
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Ran pytest
Checklist:
Others
pre-commit install.pytest tests/....