Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the legend #1854

Merged
merged 1 commit into from
May 22, 2022
Merged

Added the legend #1854

merged 1 commit into from
May 22, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented May 22, 2022

Description

Fixes #1817 no legend.

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the bug Fix bug label May 22, 2022
@colin99d colin99d requested a review from JerBouma May 22, 2022 12:23
@JerBouma
Copy link
Contributor

Does it add in the "underlying" option?

@JerBouma JerBouma merged commit 3f5d281 into main May 22, 2022
@JerBouma JerBouma deleted the add_legend branch May 22, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] /stocks/options/hedge/plot: Chart has no legend identifying the two lines.
2 participants