-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time-series forecasting (Exponential Smoothing) with Darts Integration #1851
Time-series forecasting (Exponential Smoothing) with Darts Integration #1851
Conversation
Gonna wanna also update requirements and requirements-full, which can be done as
|
Only other thing missing is the Hugo website stuff. If you look in the website folder, you can find common/prediction_techniques then follow the same pattern for editing content/ as well as data/main.yml |
So on my not M1 Mac, I seem to be able to install everything except pystan. Ill spare the errors, but they are the usual clang stuff:
Can any other non-m1 folks confirm this (cough @DidierRLopes ) |
MacOS Issues with LightGBMAt the time of writing, there is an issue with
If this works for you, I will have to update the install README for our prediction menu with regards to apple products. |
I think this might be an issue with using anaconda3 as opposed to miniconda. (Still confirming though) |
The clang issue is due to |
time_col="date", | ||
value_cols=["AdjClose"], | ||
freq="B", | ||
fill_missing_dates=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to leave this here, but it might incur a small performance penalty. If you happen to already have the guarantee beforehand that your DataFrame does not have missing dates (even if it has missing values), you can consider setting this to False.
) | ||
|
||
# Show forecast over validation # and then +n_predict afterwards sampled 10 times per point | ||
probabilistic_forecast = model_es.predict(n_predict, num_samples=10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 samples is somewhat on the low side - something like 500 would seem more reasonable to estimate the distribution. Generating these samples is fast in Numpy so it shouldn't incur any noticeable penalty, and it'll improve precision (especially as later you need the 10th and 90th percentiles).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, will update. Thanks for the insight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @hrzn ❤️
We are going to revamp our entire prediction menu with Darts and create a release around it 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome :)
So after installing with
|
It works! Had to clean up my env from goofing around yesterday with the full install, but I still get these messages on import, but I assume nothing we can do
|
This is being worked on. unit8co/darts#927 |
Yeah in order to get it I had to nuke the env and recreate. I don't think we should add this to poetry. |
Agreed. I am trying to find the proper steps to have it installed on all system architectures to then create a simple setup script. Poetry does not play nicely with all library versions. For now I am updating the install README on setup that works for M1 and Intel Macs. (5f5c618) |
I'll put this one higher on our backlog so we address it rather sooner than later. |
Looks like a side effect of loading in these libraries. When loading in stocks
Can you confirm or is this just me. Its just a warning so we can suppress. |
Can confirm, see it on my side too - definitely a lib version issue. This warning is not present on the main branch when using a normal env just from |
Description
Newly updated exponential smoothing with probabilistic forecasting utilizing Darts library
(Found inside stocks/pred/expo)
Relevant motivation and context.
Standardization, flexibility and readability of a common library.
Improved performance and features.
List any dependencies that are required for this change.
torch, darts
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.--> No, breaks on covid scripts.