Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in Guides documentation to the Hugo documentation #1845

Merged
merged 11 commits into from
May 23, 2022
Merged

Add in Guides documentation to the Hugo documentation #1845

merged 11 commits into from
May 23, 2022

Conversation

JerBouma
Copy link
Contributor

@JerBouma JerBouma commented May 20, 2022

This PR will add in the Getting Started and Introduction to Stocks guides to the Hugo docs. We will be expanding all of this greatly over time. See some examples:

Screenshot 2022-05-20 at 11 29 51

Screenshot 2022-05-20 at 11 30 03

Screenshot 2022-05-20 at 11 34 03

Before merge, the tables and lists still need to be fixed, they currently default to black.

@JerBouma JerBouma added docs Code documentation feat S Small T-Shirt size Feature labels May 20, 2022
@JerBouma
Copy link
Contributor Author

JerBouma commented May 23, 2022

@jose-donato Could you check if my adjustments to the CSS are in line what you would have expected?

In both public/main-5e7fc0c942.min.css and static/main-5e7fc0c942.min.css I added in the tables and lists HTML (tr and li):

@media (prefers-color-scheme: light) {
  h1,
  h2,
  h3,
  p,
  tr,
  li
   {
    color: white;
  }

Apparently, this also fixed this little section over here:
Screenshot 2022-05-23 at 08 20 07

The icons used to be hidden, see:
Screenshot 2022-05-23 at 08 20 41

@JerBouma JerBouma requested review from DidierRLopes and jose-donato and removed request for DidierRLopes May 23, 2022 06:27
Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, good job.

Fixed the black svg on light mode

@JerBouma JerBouma merged commit be24c3a into OpenBB-finance:main May 23, 2022
@JerBouma JerBouma deleted the update_hugo branch May 23, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Code documentation feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants