Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backtesting tz #1841

Merged
merged 2 commits into from
May 19, 2022
Merged

Fix backtesting tz #1841

merged 2 commits into from
May 19, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented May 19, 2022

Resolves #1782 and prevents from doing backtesting on intraday data (for now)

the issue in 1782 was that polygon returns dates in GMT timezone and yfinance in ET timezone

@piiq piiq added the bug Fix bug label May 19, 2022
@piiq piiq requested a review from jmaslek May 19, 2022 19:49
@jmaslek
Copy link
Collaborator

jmaslek commented May 19, 2022

With a polygon load :D

Screen Shot 2022-05-19 at 7 28 26 PM

@jmaslek jmaslek merged commit 55fc1c5 into main May 19, 2022
@DidierRLopes DidierRLopes deleted the fix-backtesting-tz branch May 30, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Backtesting features do not work when source = Polygon
2 participants