Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for updates at terminal startup #1839

Merged
merged 8 commits into from
May 20, 2022
Merged

Add check for updates at terminal startup #1839

merged 8 commits into from
May 20, 2022

Conversation

piiq
Copy link
Contributor

@piiq piiq commented May 19, 2022

  1. Retrieve the version from github releases
  2. Compare it to obbff.VERSION

image

or

image

4. Profit

@piiq piiq added feat XS Extra small feature installer installer related updated labels May 19, 2022
DidierRLopes
DidierRLopes approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a new line in the end? 😄

@piiq
Copy link
Contributor Author

piiq commented May 19, 2022

@DidierRLopes done

but out CI is broken for some other reasons

@piiq piiq merged commit 7b374b7 into main May 20, 2022
@piiq piiq deleted the check-for-updates branch May 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DidierRLopes DidierRLopes DidierRLopes approved these changes

@Chavithra Chavithra Awaiting requested review from Chavithra

Assignees
No one assigned
Labels
feat XS Extra small feature installer installer related updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piiq @DidierRLopes @jmaslek