Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up autoloading in places #1832

Merged
merged 2 commits into from
May 17, 2022
Merged

Tidy up autoloading in places #1832

merged 2 commits into from
May 17, 2022

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented May 17, 2022

Instead of adding the smart attempt at loading everywhere that load exists, only restrict it to stocks, crypto, funds and etfs.

@jmaslek jmaslek added the feat XS Extra small feature label May 17, 2022
@jmaslek jmaslek requested a review from DidierRLopes May 17, 2022 19:22
@DidierRLopes
Copy link
Collaborator

Instead of adding the smart attempt at loading everywhere that load exists, only restrict it to stocks, crypto, funds and etfs.

aren't you missing crypto and forex?

@jmaslek
Copy link
Collaborator Author

jmaslek commented May 17, 2022 •
edited
Loading

aren't you missing crypto and forex?

crypto inherits from stocks controller and forex doesn't work like load eur-usd, you have to have the to and from defined as is

@DidierRLopes
Copy link
Collaborator

aren't you missing crypto and forex?

crypto inherits from stocks controller and forex doesn't work like load eur-usd, you have to have the to and from defined as is

Meant stocks and crypto* not forex. Just because I only see a TRY_LOAD on the etf_controller and mutual_fund_controller

@DidierRLopes DidierRLopes merged commit 26781cb into OpenBB-finance:main May 17, 2022
@jmaslek jmaslek deleted the tidy_autoload branch February 14, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DidierRLopes DidierRLopes DidierRLopes approved these changes

Assignees
No one assigned
Labels
feat XS Extra small feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmaslek @DidierRLopes