Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reports and Dashboards to be one level above #1805

Merged
merged 6 commits into from
May 12, 2022
Merged

Reports and Dashboards to be one level above #1805

merged 6 commits into from
May 12, 2022

Conversation

DidierRLopes
Copy link
Collaborator

Put Reports and Dashboards 1 level above.

No need to hide them under "jupyter"

@DidierRLopes DidierRLopes added the enhancement Enhancement label May 12, 2022
@DidierRLopes DidierRLopes requested a review from jmaslek May 12, 2022 03:10
@DidierRLopes DidierRLopes requested a review from piiq May 12, 2022 03:11
@DidierRLopes DidierRLopes merged commit 37ea3fd into main May 12, 2022
@piiq piiq deleted the reports branch May 12, 2022 12:20
@joshuabuildsthings
Copy link
Contributor

@DidierRLopes - FYI, it looks like the ipynb files under Reports & Dashboards are gone now.

  1. https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/openbb_terminal/dashboards
  2. https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/openbb_terminal/reports

@piiq
Copy link
Contributor

piiq commented May 12, 2022

Argh

@DidierRLopes
Copy link
Collaborator Author

@DidierRLopes - FYI, it looks like the ipynb files under Reports & Dashboards are gone now.

  1. https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/openbb_terminal/dashboards
  2. https://github.com/OpenBB-finance/OpenBBTerminal/tree/main/openbb_terminal/reports

God dammit. With moving the directories it must have not moved them across on remote. So annoying and silly. Will fix now, thanks for letting me know and sorry about that!

DidierRLopes added a commit that referenced this pull request May 12, 2022
@DidierRLopes
Re-add notebooks removed by #1805 (#1812)
a7c1480 
* bring dashboards and reports menus one step above

* remove checkpoints

* add notebooks again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose-donato jose-donato jose-donato approved these changes

@jmaslek jmaslek Awaiting requested review from jmaslek

@piiq piiq Awaiting requested review from piiq

Assignees
No one assigned
Labels
enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DidierRLopes @joshuabuildsthings @piiq @jose-donato