Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /crypto/ta/kc implementation #1799

Merged
merged 4 commits into from
May 11, 2022

Conversation

alexferrari88
Copy link
Contributor

Description

In #1793 it has been reported that despite kc is listed as command in crypto/ta, this was not implemented. This PR fixes that by implementing the kc command.

How has this been tested?

$> crypto
$ crypto> load btc
$ crypto> ta/kc

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@alexferrari88 alexferrari88 changed the title Add /crypto/ta/kc implementation #1793 Add /crypto/ta/kc implementation May 11, 2022
@DidierRLopes DidierRLopes added the bug Fix bug label May 11, 2022
@DidierRLopes DidierRLopes merged commit ef73d8b into OpenBB-finance:main May 11, 2022
@alexferrari88 alexferrari88 deleted the feature/crypto_kc_bug branch May 12, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants