Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto loading for Binance #1795

Merged

Conversation

alexferrari88
Copy link
Contributor

Description

In #1794, it is reported that trying to load cryptos with Binance using small caps letters (e.g. btc vs BTC) for the crypto name, generates an error. This is due to Binance not accepting small caps letters for crypto names. This PR fixes that.

How has this been tested?

$> crypto
`$ crypto> load -c btc --source bin

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Copy link
Collaborator

@jmaslek jmaslek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn. Bug fix in record time 🚀🚀🚀

@jmaslek jmaslek added the bug Fix bug label May 11, 2022
@alexferrari88
Copy link
Contributor Author

Damn. Bug fix in record time 🚀🚀🚀

In all fairness, this was a super easy one 😄

@DidierRLopes DidierRLopes merged commit 14a800d into OpenBB-finance:main May 11, 2022
@alexferrari88 alexferrari88 deleted the feature/binance_load_bug branch May 11, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants