Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patternize validation of axes count with typo fix #1781

Merged
merged 17 commits into from
May 17, 2022

Conversation

PzaThief
Copy link
Contributor

@PzaThief PzaThief commented May 7, 2022

in view functions axis validation and store variable codes have many errors of below situations and have problem about hard to read.

  1. mismatch between validation code and unpacking to store variable
  2. mismatch between validation code and console print message
  3. mismatch between validation code and parameter docs
    etc.

So I made pattern about validation of axes count and fix typos.
I tried to check error of my commit as far as possible, but there can be errors. So please let me know if anyone finds errors.

@DidierRLopes DidierRLopes added bug Fix bug enhancement Enhancement labels May 7, 2022
@DidierRLopes DidierRLopes requested a review from piiq May 7, 2022 23:57
@DidierRLopes
Copy link
Collaborator

I like what you did there! @PzaThief 🚀

Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙌
I've left a request for type-hints and a docstring

openbb_terminal/helper_funcs.py Show resolved Hide resolved
@Chavithra Chavithra self-requested a review May 17, 2022 11:37
@Chavithra Chavithra requested a review from piiq May 17, 2022 12:17
@Chavithra
Copy link
Contributor

Chavithra commented May 17, 2022

Did some updates :

  • Fixed bugs and linting
  • Did some simplification
  • Resolved conflicts with main

@piiq I let you check again before merging

@Chavithra Chavithra removed their request for review May 17, 2022 13:22
@Chavithra Chavithra merged commit 2815f42 into OpenBB-finance:main May 17, 2022
@piiq
Copy link
Contributor

piiq commented May 17, 2022

thanks @PzaThief

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants