-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comparisons between the portfolio and benchmark including an orderbook sheet #1773
Conversation
@jmaslek Initial set-up of the Portfolio menu but have a look if you like. Still a lot to do though. |
I kind of want to merge this PR before it gets too big. Especially since I have little time to work on it. Think I made some decent progress others can build on top of. So if one of you can review it that would be great. |
looking through images: spelling:
The zeros show as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple small comments on printing but the rest looks good to me for now
You also goofed the main terminal menu:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2022 May 12, 14:43 (🦋) /portfolio/ $ load Public_Equity_Orderbook.xlsx
Portfolio: Public_Equity_Orderbook.xlsx
Risk Free Rate: 0
2022 May 12, 14:43 (🦋) /portfolio/ $ rolling
Error: 'Portfolio' object has no attribute 'benchmark_returns'
So this is just me typing too quickly and thus the next command I am typing also showing. Will fix date format. |
@jmaslek Should all be fixed now and made some tables look a bit nicer. |
Description
This menu will be featuring a whole bunch of portfolio attribution commands. This allows you to understand how your portfolio performed via a variety of metrics comparing it to a benchmark to determine any alpha obtained. This is absolutely crucial to determine if active management has been beneficial.
Makes use of an orderbook sheet:
Determine allocation differences between portfolio and benchmark (assets, sectors, countries and regions):
Checklist:
Others
pre-commit install
.pytest tests/...
.