Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some linting errors #1763

Conversation

alexferrari88
Copy link
Contributor

Description

Pylint (at least locally) keeps on complaining about several issues. In this PR I have addressed some of them. If you look at them, it makes sense that pylint complains :)

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

Copy link
Collaborator

@DidierRLopes DidierRLopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! Thank you Alex!

@DidierRLopes DidierRLopes added bug Fix bug enhancement Enhancement and removed bug Fix bug labels May 5, 2022
@DidierRLopes DidierRLopes merged commit add153f into OpenBB-finance:main May 5, 2022
@alexferrari88 alexferrari88 deleted the feature/fix_some_linting_errors branch May 5, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants