Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves PO controller from UX perspective #1760

Merged
merged 9 commits into from
May 4, 2022
Merged

Improves PO controller from UX perspective #1760

merged 9 commits into from
May 4, 2022

Conversation

DidierRLopes
Copy link
Collaborator

@DidierRLopes DidierRLopes commented May 3, 2022

This PR does the following:

  • Improve UX of PO menu to be more intuitive
  • Commands unavailable when portfolio not loaded
  • Fix reset to re-load portfolio and re-load params
  • Remove add/rmv commands
  • Allow -h in load and file cmd

@DidierRLopes DidierRLopes added the feat S Small T-Shirt size Feature label May 3, 2022
@DidierRLopes DidierRLopes requested a review from JerBouma May 3, 2022 15:44
@JerBouma
Copy link
Contributor

JerBouma commented May 4, 2022

@DidierRLopes If you haven't already, could you also look into this:

/portfolio/po/load & file do not show a help dialogue with -h flag

(🦋) /portfolio/po/ $ load -h
usage: load -f FILE [FILE ...] [-h]
load: error: the following arguments are required: -f/--file

@DidierRLopes
Copy link
Collaborator Author

@DidierRLopes If you haven't already, could you also look into this:

/portfolio/po/load & file do not show a help dialogue with -h flag

(🦋) /portfolio/po/ $ load -h
usage: load -f FILE [FILE ...] [-h]
load: error: the following arguments are required: -f/--file

Yup, let me do that now :)

@DidierRLopes
Copy link
Collaborator Author

@DidierRLopes If you haven't already, could you also look into this:
/portfolio/po/load & file do not show a help dialogue with -h flag

(🦋) /portfolio/po/ $ load -h
usage: load -f FILE [FILE ...] [-h]
load: error: the following arguments are required: -f/--file

Yup, let me do that now :)

Should be done now @JerBouma

Copy link
Contributor

@JerBouma JerBouma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@DidierRLopes DidierRLopes merged commit 30d657b into main May 4, 2022
@DidierRLopes DidierRLopes deleted the po-improv branch May 10, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants