-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow exporting from stocks/ca/hcorr #1759
Conversation
Nice work @alexferrari88 !! 🦋 |
@alexferrari88 you just need to have linting tests to pass. You can do |
btw this is my first ever PR for a public project so forgive my naivete :) |
We hope that this is the first of many 🤩 |
This project was my first PR on a public project as well :) |
@alexferrari88 legend! 🚀 |
Description
The exporting function for stocks/ca/hcorr is documented but not implemented as reported by issue #1752. This PR solves that.
How has this been tested?
$> stocks/ca
$ stocks/ca> set XLE,XLK,XLY,XLI,XLP,XLC,XLV,XLF,XLU,XLB,XLRE
$ stocks/ca> hcorr --export png
Checklist:
Others
pre-commit install
.pytest tests/...
.