Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow exporting from stocks/ca/hcorr #1759

Merged
merged 6 commits into from
May 3, 2022

Conversation

alexferrari88
Copy link
Contributor

@alexferrari88 alexferrari88 commented May 3, 2022

Description

The exporting function for stocks/ca/hcorr is documented but not implemented as reported by issue #1752. This PR solves that.

How has this been tested?

$> stocks/ca
$ stocks/ca> set XLE,XLK,XLY,XLI,XLP,XLC,XLV,XLF,XLU,XLB,XLRE
$ stocks/ca> hcorr --export png

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@alexferrari88 alexferrari88 changed the title Allow exporting from stocks/ca/hcorr #1752 Allow exporting from stocks/ca/hcorr May 3, 2022
@DidierRLopes DidierRLopes added the bug Fix bug label May 3, 2022
@DidierRLopes
Copy link
Collaborator

Nice work @alexferrari88 !! 🦋

@DidierRLopes
Copy link
Collaborator

@alexferrari88 you just need to have linting tests to pass. You can do black file path

@alexferrari88
Copy link
Contributor Author

btw this is my first ever PR for a public project so forgive my naivete :)

@DidierRLopes
Copy link
Collaborator

btw this is my first ever PR for a public project so forgive my naivete :)

We hope that this is the first of many 🤩

@jmaslek
Copy link
Collaborator

jmaslek commented May 3, 2022

btw this is my first ever PR for a public project so forgive my naivete :)

This project was my first PR on a public project as well :)

@piiq
Copy link
Contributor

piiq commented May 3, 2022

@alexferrari88 legend! 🚀

@piiq piiq merged commit 6b4987f into OpenBB-finance:main May 3, 2022
@alexferrari88 alexferrari88 deleted the feature/hcorr_export branch May 4, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants