Polygon stock load

[jmaslek]

Adding in load --source polygon from polygon.io

The free tier allows 5 calls/minute and it seems that the minute calls give a lotto data, up to 50,000 entries... We already have polygon API key in the terminal.

More to come :D

I did tests

edit: I did more

@deeleeramone here are figi and SIK codes from polygon's endpoint

            AAPL Codes             
┏━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃                  ┃              ┃
┡━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ CIK              │ 0000320193   │
├──────────────────┼──────────────┤
│ COMPOSITE FIGI   │ BBG000B9XRY4 │
├──────────────────┼──────────────┤
│ SHARE CLASS FIGI │ BBG001S5N8V8 │
├──────────────────┼──────────────┤
│ SIC CODE         │ 3571         │
└──────────────────┴──────────────┘

[DidierRLopes]

Is this worth being a command?

Also, we should only display this command if there is a valid polygon key

[jmaslek]

yes.

we show the news line even if there is not a valid news api key

[DidierRLopes]

Does the Polygon data here can be accessed with their free tier? if yes, nvm my comment. If not, let's hide it for users that don't have a valid paid API key

[jmaslek]

Yup :D afaik everything they have can be accessed through the free tier.

[DidierRLopes]

So nevermind what I said!

[DidierRLopes]

let's load config_terminal as cfg and then use cfg.API_POLYGON_KEY. That's how we doing in the other places

[jmaslek]

from your last PR: why would I import config terminal twice?

[DidierRLopes]

I honestly don't like implicit imports. I think having cfg.theme is much more visible where that comes from, and would rather us doing that

[jmaslek]

just tryna use your code against you ;)

[jmaslek]

that also imports everything and is why we initially had such slow load times

[DidierRLopes]

config_terminal is always loaded even if you do from config_terminal import theme it just creates that theme reference on the file.

The slow load times were "solved" by putting the import within a command, not based on how we load a module.

I am still a pain 😄

[jmaslek]

that you are <3

now approve

[deeleeramone]

OH BABY! That’s the missing link in the stock search! Search —> codes —> symbols —> long name —> description

…

On May 3, 2022, at 6:28 AM, didierlopes.eth ***@***.***> wrote: @DidierRLopes requested changes on this pull request. In openbb_terminal/parent_classes.py <#1757 (comment)>: > @@ -438,7 +438,9 @@ def call_load(self, other_args: List[str]): "--source", action="store", dest="source", - choices=["yf", "av", "iex"] if "-i" not in other_args else ["yf"], + choices=["yf", "av", "iex", "polygon"] + if "-i" not in other_args or --interval In openbb_terminal/stocks/stocks_controller.py <#1757 (comment)>: > @@ -111,7 +112,9 @@ def print_help(self): {self.add_info}[cmds] quote view the current price for a specific stock ticker candle view a candle chart for a specific stock ticker - news latest news of the company[/cmds] [src][News API][/src] + news latest news of the company [src][News API][/src] + codes FIGI, SIK and SIC codes codes[/cmds] [src][Polygon.io][/src] Is this worth being a command? Also, we should only display this command if there is a valid polygon key In openbb_terminal/stocks/stocks_helper.py <#1757 (comment)>: > import yfinance as yf from alpha_vantage.timeseries import TimeSeries from numpy.core.fromnumeric import transpose from plotly.subplots import make_subplots from scipy import stats -from openbb_terminal.config_terminal import theme +from openbb_terminal.config_terminal import theme, API_POLYGON_KEY let's load config_terminal as cfg and then use cfg.API_POLYGON_KEY. That's how we doing in the other places — Reply to this email directly, view it on GitHub <#1757 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUOMPBVNAUQGCFQUZE3SAQLVIESY5ANCNFSM5U5TIQTQ>. You are receiving this because you were mentioned.