Improve OpenBB API for investment research reports #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DidierRLopes
changed the title
|
The image should be good now. Converted to base64 and then rendered the image. also fixed some other HTML stuff |
piiq
requested changes
May 3, 2022
| @@ -47,11 +48,9 @@ | |||
| ) | |||
|
|
|||
| # Models | |||
| # NOTE: The raw function is used here to point to the commons path where all the | |||
There was a problem hiding this comment.
I don't remember why I've implemented it like this 😂
| @@ -28,7 +28,7 @@ class ReportController(BaseController): | |||
| reports_folder = os.path.dirname(os.path.abspath(__file__)) | |||
|
|
|||
| report_names = [ | |||
| notebooks.strip(".ipynb") | |||
| notebooks[:-6] | |||
There was a problem hiding this comment.
Took me some time to figure out that the strip was problematic. I had misunderstood it's usage. See
| @@ -207,7 +186,7 @@ def darkpool_otc( | |||
| num: int, | |||
| promising: int, | |||
| tier: str, | |||
There was a problem hiding this comment.
Is there a way to have a default kwarg for the tier? It's a string and giving a default kwarg would make it easier to understand what it looks like
|
@piiq should be good now :) |
|
@DidierRLopes no, it's not |
…l into darkpoolapi
|
Should be now @piiq |
piiq
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved a LOT of small things on the API:
@piiq @jose-donato this is silly but how can we have the OpenBB_reports_logo.png image appearing on the report when this is run from the reports controller?