Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to determine Reddit sentiment about a ticker/company. #1744

Merged

Conversation

jbushago
Copy link
Contributor

Description

This PR adds a new command reddit_sent to the terminal under stocks/ba. This command searches through subreddits for a given ticker (or company name), aggregates/preprocesses its findings, and then determines the overall sentiment about the query (with an optional graphic).

It's a quick way to get a general understanding about how different communities feel about a company/ticker. An example usage is shown below:
image

No new dependencies are needed for the command.

How has this been tested?

All tests pass after these changes.

Others

@cweckerl, @montoys, and I all worked on the implementation and review.

@colin99d colin99d self-requested a review April 26, 2022 18:16
@colin99d colin99d added the feat XS Extra small feature label Apr 27, 2022
Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbushago @cweckerl @montoys you are awesome! 🚀🚀🚀
Thank you for this contribution. I've already started playing with the functions that you've added (and thinking about incorporating them to my routines ... hehe)

I have left a bunch of suggestions in the code. Not mandatory

But there's one thing related to the sentiment chart that I would like you to change (see comment). Feel free to tag me if you have any questions

@jbushago
Copy link
Contributor Author

@piiq
Thank you so much for the review! We really appreciate it :). We've gone ahead and implemented your suggestions, let us know if there's more to change.

@jbushago jbushago requested a review from piiq April 27, 2022 14:54
@piiq piiq added feat S Small T-Shirt size Feature and removed feat XS Extra small feature labels Apr 27, 2022
@piiq piiq merged commit e2e4288 into OpenBB-finance:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants