Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Crypto Tests #1743

Merged
merged 11 commits into from
May 10, 2022
Merged

Refactored Crypto Tests #1743

merged 11 commits into from
May 10, 2022

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Apr 26, 2022

Description

Refactored cryptocurrency helpers to match how we do tests now.

How has this been tested?

Ran the tests.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@colin99d colin99d added the tests Test-related work label Apr 26, 2022
@colin99d colin99d requested a review from Chavithra April 26, 2022 14:10
@colin99d colin99d marked this pull request as draft April 26, 2022 15:48
@colin99d colin99d marked this pull request as ready for review April 26, 2022 18:15
Copy link
Contributor

@Chavithra Chavithra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Chavithra Chavithra merged commit 9068ad0 into main May 10, 2022
@colin99d colin99d deleted the moretests branch May 10, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test-related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants