Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ross index #1723

Merged
merged 7 commits into from
Apr 22, 2022
Merged

Adds ross index #1723

merged 7 commits into from
Apr 22, 2022

Conversation

jose-donato
Copy link
Contributor

Description

Adds new command to oss menu.
rossidx shows the fastest-growing open-source startups from Runa Capital source
image
image

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato added the feat XS Extra small feature label Apr 20, 2022
@jmaslek
Copy link
Collaborator

jmaslek commented Apr 20, 2022

For the table, since the GitHub gets chopped off very quickly, does it look good if you try using text wrap to that column?

@piiq
Copy link
Contributor

piiq commented Apr 20, 2022

Would hbars be better here for readability of the labels?

@jose-donato
Copy link
Contributor Author

Will try those two things

@jose-donato
Copy link
Contributor Author

Fixed @jmaslek table issue and updated charts to match @piiq suggestion

Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my initial suggestion was to have the charting with the following convention

rossidx --chart -ct stars
rossidx --chart -ct forks
rossidx --chart -ct growth

but i like what you've done more 💪

@jose-donato
Copy link
Contributor Author

my initial suggestion was to have the charting with the following convention

rossidx --chart -ct stars
rossidx --chart -ct forks
rossidx --chart -ct growth

but i like what you've done more 💪

nice!
the only problem with that is that there is forks annual growth and stars annual growth, even though runacap just shows the stars (+ stars annual growth) on the chart on their website :)

@jmaslek
Copy link
Collaborator

jmaslek commented Apr 21, 2022

my initial suggestion was to have the charting with the following convention

rossidx --chart -ct stars
rossidx --chart -ct forks
rossidx --chart -ct growth

but i like what you've done more 💪

nice! the only problem with that is that there is forks annual growth and stars annual growth, even though runacap just shows the stars (+ stars annual growth) on the chart on their website :)

also the argparse names should stick to one letter for one - (@DidierRLopes yelled at me before as this is the unix convention)

@jose-donato
Copy link
Contributor Author

my initial suggestion was to have the charting with the following convention

rossidx --chart -ct stars
rossidx --chart -ct forks
rossidx --chart -ct growth

but i like what you've done more 💪

nice! the only problem with that is that there is forks annual growth and stars annual growth, even though runacap just shows the stars (+ stars annual growth) on the chart on their website :)

also the argparse names should stick to one letter for one - (@DidierRLopes yelled at me before as this is the unix convention)

yup that's true, will change

@jose-donato jose-donato merged commit 05c0ea0 into main Apr 22, 2022
@jose-donato jose-donato deleted the ross branch April 22, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat XS Extra small feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants