Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try a "smart" load of tickers #1722

Merged
merged 5 commits into from
Apr 28, 2022
Merged

Conversation

jmaslek
Copy link
Collaborator

@jmaslek jmaslek commented Apr 20, 2022

Tired of going into stocks then just tryna smash your favorite tickers just to get told that TSLA isn't on the stocks menu?

Well now it is :P

Screen Shot 2022-04-20 at 2 36 53 PM

But what about just wanting to look at that cute dog coin?

I gotchu

Screen Shot 2022-04-20 at 2 38 01 PM

This lives in BaseClass and only gets attempted when load exists in choices.

Is it perfect? Hell no.

2022 Apr 20, 14:38 (🦋) /crypto/ $ load cndle
Could not find coin with given id: cndle

Does it still auto-complete? Hello yeah

The command 'cndle' doesn't exist on the /stocks/ menu.
 Replacing by 'candle'.

Does it break logs? No idea. @Chavithra @LBolte29 :)

Copy link
Contributor

@colin99d colin99d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-04-26 at 8 52 17 AM

Works flawlessly!

@deeleeramone
Copy link
Contributor

image

@jmaslek jmaslek merged commit 2619917 into OpenBB-finance:main Apr 28, 2022
@jmaslek jmaslek deleted the stock_load branch February 14, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants