Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crypto load #1715

Merged
merged 18 commits into from
Apr 25, 2022
Merged

Fix crypto load #1715

merged 18 commits into from
Apr 25, 2022

Conversation

jose-donato
Copy link
Contributor

Description

Addresses #1701

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@jose-donato jose-donato added the bug Fix bug label Apr 19, 2022
@piiq
Copy link
Contributor

piiq commented Apr 21, 2022

not there yet?

image

image

@minhhoang1023
Copy link
Contributor

minhhoang1023 commented Apr 25, 2022

Now we are able to load crypto coins via symbol, instead of coin-id specific to each data source.

image

image

image

However, crypto load at the moment is still very buggy, and relies on a complicated, and hard-to-maintain crypto map between multiple data sources. I have been discussing with @jose-donato and we should refactor the code. This PR is a quick fix, so that users can load symbol in the mean time

@minhhoang1023 minhhoang1023 merged commit d06fe1b into main Apr 25, 2022
@piiq piiq deleted the fix_crypto_load branch April 28, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants