Add Messari crypto dd commands #1711

jose-donato · 2022-04-18T18:48:25Z

Description

WIP

How has this been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Checklist:

Update our Hugo documentation following these guidelines.
Update our tests following these guidelines.
Make sure you are following our CONTRIBUTING guidelines.
If a feature was added make sure to add it to the corresponding scripts file.

Others

I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

DidierRLopes · 2022-04-18T21:28:55Z

tests/openbb_terminal/cryptocurrency/due_diligence/txt/test_dd_controller/test_print_help.txt

@@ -37,3 +37,12 @@ Coinbase
   stats           show coin stats
 Messari
   mcapdom         show market cap dominance
+   mt              show messari timeseries


no need for the "show" on the description in all of these

minhhoang1023 · 2022-04-20T11:52:34Z

Excellent work 🚀 ✨ This totally revamped the DD menu

minhhoang1023 · 2022-04-20T11:57:07Z

Was going through it and have a few comments:

Roadmap command
I remembered you mentioned the idea of plotting this as a plot, together with the price, to show how the news impacts the price. Shall we make it happen?

There's some href HTML tags left in the text

minhhoang1023 · 2022-04-20T16:48:17Z

For circulating supply, what do you think about adding the price indicator? If the project keeps on minting new tokens without increasing demand, price will inevitably decrease as per econ 101.

minhhoang1023 · 2022-04-20T16:51:49Z

For tk command, I got an error when loading ETH. Does it happen to you too?

Same with investors & fundraising & links command

minhhoang1023 · 2022-04-27T08:48:31Z

Already said it, but I'm going to say it again, you're killing this @jose-donato - basically adding half of what we are having to the dd menu 🚀 From my interviews with users, they absolutely need these commands. Instead of having to navigate through multiple sites, now they can find it all in the terminal.

minhhoang1023 · 2022-04-27T08:50:02Z

A few small comments:

We should remove the list of time series in the mt command. The list is massive and i need to scroll a lot. Now that we have the query option, we no longer need this.

minhhoang1023 · 2022-04-27T09:44:54Z

NaT should be displayed as Unknown / or Not specified or sth humand-readable. i'll leave it up to you.

The href tag is still showing :( .

minhhoang1023 · 2022-04-27T09:06:37Z

openbb_terminal/cryptocurrency/due_diligence/dd_controller.py

+        parser.add_argument(
+            "-q",
+            "--query",
+            type=str,


could we have it such that it will print out a table of possible time series similar to what we discussed before? Right now, it's not printing out anything, and still using the default of Transaction Volume

minhhoang1023 · 2022-04-27T09:13:34Z

openbb_terminal/cryptocurrency/due_diligence/dd_controller.py

@@ -136,6 +139,8 @@ def __init__(
            choices["twitter"]["-s"] = {
                c: None for c in coinpaprika_view.TWEETS_FILTERS
            }
+            choices["mt"] = {c: None for c in self.messari_timeseries}


Do you think it's possible to display the Title of Time Series for auto-completion instead of id? Then we can do the mapping later.

minhhoang1023 · 2022-04-27T09:22:20Z

openbb_terminal/cryptocurrency/due_diligence/messari_view.py

+        ax.plot(df.index, df["values"])
+
+        ax.set_title(f"{coin}'s {title}")
+        ax.set_ylabel(y_axis)


We can use the title as the plot title, to avoid the overflowing text

minhhoang1023 · 2022-04-27T09:27:04Z

openbb_terminal/cryptocurrency/due_diligence/glassnode_model.py

@@ -214,15 +218,18 @@ def get_close_price(asset: str, interval: str, since: int, until: int) -> pd.Dat
        df = pd.DataFrame(json.loads(r.text))

        if df.empty:
-            console.print(f"No data found for {asset} price.\n")
+            if print_errors:
+                console.print(f"No data found for {asset} price.\n")
        else:
            df = df.set_index("t")
            df.index = pd.to_datetime(df.index, unit="s")

    elif r.status_code == 401:


This should be the Premium API Feat, instead of invalid API key.

We have the template on API error handling here - you might need to update depending on their status code

if response.status_code == 200: d_data = response.json() if "economicCalendar" in d_data: df = pd.DataFrame(d_data["economicCalendar"]) else: console.print("No latest economy calendar events found\n") elif response.status_code == 401: console.print("[red]Invalid API Key[/red]\n") elif response.status_code == 403: console.print("[red]API Key not authorized for Premium Feature[/red]\n") else: console.print(f"Error in request: {response.json()['error']}", "\n") return df

minhhoang1023 · 2022-04-27T09:43:34Z

openbb_terminal/cryptocurrency/due_diligence/dd_controller.py

+            action="store_true",
+            help="Flag to show chart with coin price and roadmap dates",
+            dest="chart",
+            default=False,


default should be True, so they can see your awesome chart ;)

minhhoang1023 · 2022-04-27T09:50:47Z

openbb_terminal/cryptocurrency/due_diligence/messari_view.py

+
+    if not df.empty:
+        df["Date"] = df["Date"].dt.date
+        print_rich_table(


Very small but this will add to user experience. It'd be nice to have this sort by date (descending) so we show the latest roadmap first, and have a limit flag. We could show top 5 as default, as otherwise it'd be rather long.

minhhoang1023 · 2022-04-27T10:09:49Z

openbb_terminal/cryptocurrency/due_diligence/messari_view.py

+    external_axes : Optional[List[plt.Axes]], optional
+        External axes (1 axis is expected in the list), by default None
+    """
+    df, circ_df = get_tokenomics(coin, coingecko_symbol, circ_supply_src)


Got this error msg if it's from cg

minhhoang1023 · 2022-04-27T10:15:43Z

openbb_terminal/cryptocurrency/due_diligence/messari_view.py

+
+@log_start_end(log=logger)
+@check_api_key(["API_MESSARI_KEY"])
+def display_fundraising(


Any idea why the investor % and org % doesn't match between the chart and text? With ETH it's matching tho so might be due to Messari itself?

minhhoang1023 · 2022-04-27T10:56:10Z

I also added a prettify_paragraph to make the text look nicer :D

Before:

After:

This reverts commit ab4c01d.

This reverts commit 9de8474.

Chavithra · 2022-05-02T12:38:57Z

@jose-donato Looks like the tests fail was related to file naming : case sensitivity

added dd messari funcs

61b19ca

jose-donato added the feat L Large T-Shirt size Feature label Apr 18, 2022

updated test

0052140

DidierRLopes reviewed Apr 18, 2022

View reviewed changes

jose-donato added 3 commits April 21, 2022 12:20

fix some issues, added price to circ supply, roadmap

7da65e7

merge with main

1426173

added docs

8bd9723

jose-donato added feat XL Extra Large feature and removed feat L Large T-Shirt size Feature labels Apr 26, 2022

jose-donato added 3 commits April 26, 2022 16:25

updated crypto dd script

e86c611

Merge branch 'main' into messari_dd

aa6fb56

updated model tests

e1fd37a

jose-donato marked this pull request as ready for review April 26, 2022 15:51

jose-donato requested a review from minhhoang1023 April 26, 2022 15:52

minhhoang1023 reviewed Apr 27, 2022

View reviewed changes

Prettify paragraphs

c81dc6d

jose-donato and others added 6 commits April 28, 2022 18:36

pr issues

2284b57

merge in main broke tests

a135d57

fixed tests

fc2919f

updated tests

8657124

updated tests

573ca63

Merge branch 'main' into messari_dd

a214c3d

Chavithra added 7 commits May 2, 2022 13:25

Tests : cryptocurrency/due_diligence/messari_model

a98cf37

Tests : cryptocurrency/due_diligence/messari_model

9de8474

Tests : messari

ab4c01d

Revert "Tests : messari"

78ed82a

This reverts commit ab4c01d.

Revert "Tests : cryptocurrency/due_diligence/messari_model"

2626eac

This reverts commit 9de8474.

Tests : messari fix case issue

bcb4a1f

Black

9e8c481

jose-donato requested review from minhhoang1023 and DidierRLopes May 2, 2022 13:34

DidierRLopes approved these changes May 2, 2022

View reviewed changes

DidierRLopes merged commit e3cd8ad into main May 2, 2022

DidierRLopes deleted the messari_dd branch May 30, 2022 10:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Messari crypto dd commands #1711

Add Messari crypto dd commands #1711

jose-donato commented Apr 18, 2022 •

edited

Loading

DidierRLopes Apr 18, 2022

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022 •

edited

Loading

minhhoang1023 commented Apr 27, 2022

minhhoang1023 commented Apr 27, 2022

minhhoang1023 commented Apr 27, 2022 •

edited

Loading

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 Apr 27, 2022

minhhoang1023 commented Apr 27, 2022

Chavithra commented May 2, 2022 •

edited

Loading

Add Messari crypto dd commands #1711

Add Messari crypto dd commands #1711

Conversation

jose-donato commented Apr 18, 2022 • edited Loading

Description

How has this been tested?

Checklist:

Others

Choose a reason for hiding this comment

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022

minhhoang1023 commented Apr 20, 2022 • edited Loading

minhhoang1023 commented Apr 27, 2022

minhhoang1023 commented Apr 27, 2022

minhhoang1023 commented Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minhhoang1023 commented Apr 27, 2022

Chavithra commented May 2, 2022 • edited Loading

jose-donato commented Apr 18, 2022 •

edited

Loading

minhhoang1023 commented Apr 20, 2022 •

edited

Loading

minhhoang1023 commented Apr 27, 2022 •

edited

Loading

Chavithra commented May 2, 2022 •

edited

Loading