-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crypto DD commands #1710
Add crypto DD commands #1710
Conversation
…onkTerminal into add-dd-commands
@minhhoang1023 this file path is not compatible with Windows : The issue comes from the character |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this activity count mean? number of commits? Maybe we can clarify on the chart?
Just a detail but can we prettify the column names? How to do it [here](https://github.com/OpenBB-finance/OpenBBTerminal/blob/e1fd37a5273b2307b3a8e3eb3e117a9b1375b57e/openbb_terminal/cryptocurrency/due_diligence/messari_model.py#L362)Apart from these small details awesome work as always 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice
Can you also add these commands to a test***.openbb file in the scripts folder?
@piiq @jose-donato Was looking for this detailed level of review. Thanks guys 🚀 All done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This reverts commit e59a30b.
Adding
gh
(github_activity) andnews
commandDescription
How has this been tested?
Checklist:
Others
pre-commit install
.pytest tests/...
.