Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypto DD commands #1710

Merged
merged 30 commits into from
Apr 27, 2022
Merged

Add crypto DD commands #1710

merged 30 commits into from
Apr 27, 2022

Conversation

minhhoang1023
Copy link
Contributor

@minhhoang1023 minhhoang1023 commented Apr 18, 2022

Adding gh (github_activity) and news command

image

image

Description

  • Summary of the change / bug fix.
  • Link # issue, if applicable.
  • Screenshot of the feature or the bug before/after fix, if applicable.
  • Relevant motivation and context.
  • List any dependencies that are required for this change.

How has this been tested?

  • Please describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.

Checklist:

Others

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code passes all the checks pylint, flake8, black, ... To speed up development you should run pre-commit install.
  • New and existing unit tests pass locally with my changes. You can test this locally using pytest tests/....

@minhhoang1023 minhhoang1023 marked this pull request as ready for review April 22, 2022 11:39
@minhhoang1023 minhhoang1023 added the feat S Small T-Shirt size Feature label Apr 22, 2022
@minhhoang1023 minhhoang1023 marked this pull request as ready for review April 25, 2022 13:55
@Chavithra
Copy link
Contributor

Chavithra commented Apr 26, 2022

@minhhoang1023 this file path is not compatible with Windows :
tests/openbb_terminal/cryptocurrency/due_diligence/csv/test_santiment_model/test_get_github_activity[BTC-True-1d-2022-01-10T00:00:00Z-2022-03-08T00:00:00Z].csv

The issue comes from the character : which is not supported by Windows.

Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

What does this activity count mean? number of commits? Maybe we can clarify on the chart?

image

Just a detail but can we prettify the column names? How to do it [here](https://github.com/OpenBB-finance/OpenBBTerminal/blob/e1fd37a5273b2307b3a8e3eb3e117a9b1375b57e/openbb_terminal/cryptocurrency/due_diligence/messari_model.py#L362)

Apart from these small details awesome work as always 🚀

Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice
Can you also add these commands to a test***.openbb file in the scripts folder?

@minhhoang1023
Copy link
Contributor Author

@piiq @jose-donato Was looking for this detailed level of review. Thanks guys 🚀 All done!

Copy link
Contributor

@piiq piiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@jose-donato jose-donato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@minhhoang1023 minhhoang1023 merged commit e59a30b into main Apr 27, 2022
@piiq piiq deleted the add-dd-commands branch April 27, 2022 12:50
Chavithra added a commit to Chavithra/OpenBBTerminal that referenced this pull request Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat S Small T-Shirt size Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants